Hated my on-demand water heater from the beginning. Finally ripped it out and put in a tank model. It is hands and fists better than the tankless.
My tankless was set at its max temp of 124 degrees. Getting hot water to anything but the kitchen sink was iffy. You have to run the faucets at a high output to get the water heater to turn on. Then you have to wait for it to get to the faucet. Turn off the faucet for a second and the heater shuts off. Then you get cold water in a section that will be coming next.
If you dry camp at all, GO WITH THE TANK MODEL. Otherwise you will waste a lot of water and holding tank space while standing there swearing at your hot water availability. My tank model puts out 135 degrees and can now burn your dish washing hands which is nice.
If you are always hooked up the only thing you need to think about is how much water you feel comfortable wasting. Since I am in Southern California and we are basically in and out of drought conditions all the time, I have grown to have a great respect for water and wasting it just pisses me off.